-
Notifications
You must be signed in to change notification settings - Fork 341
alpha-ctsm5.4.CMIP7.19.ctsm5.3.085: Update ctsm5.4 alpha branch to ctsm5.3.085 #3625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpha-ctsm5.4.CMIP7.19.ctsm5.3.085: Update ctsm5.4 alpha branch to ctsm5.3.085 #3625
Conversation
b4b-dev merge 2025-10-16
Merge ctsm5.3.080 into b4b-dev
…tream docs-build-and-deploy: Only run on upstream
…e for CTSM, this compiles with intel on Derecho
… in the local object
…into carbon_isotopes_in_streams
… CTSM stream base type
…ve memory when appropriate
…e method a bit, so that varnames and name aren't sent in, also have to make sdat public, so that the dshr_fldbun_getFldPtr method can use it's internal components
…s for C13/C14 timeseries handling
…ilename was incorrect as well as a typo for C13 in the Advance and Interp routines
…n be used easier in the code, this increases memory, but matches the rest of CTSM better and isolates the handling of the grid for the C14 data which makes it easier for the grid to change, this is a prestep to moving to streams as this is how streams works
…mfile set_paramfile: Allow simply setting all of a parameter to a single value
|
Derecho testing of aux_clm is as expected other than this test: RXCROPMATURITYSKIPGEN_Ld1097.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput which failed at RUN. It passes in the previous alpha 19 tag off of ctsm5.3.082 and it passes in ctsm5.3.085. I'm resubmitting to see if that solves it. |
|
Erik, if I'm looking in the correct directory Is it not finding this file |
|
That file exists, so is it failing to find a datm file, such as |
|
That one also exists. I think the name of the file that doesn't exist is not appearing in the log files... |
|
It looks like the problem is due to #2930 which I just closed and then realized it needed to be reopened. The problem occurs at runtime rather than preview_namelist time right now. My inclination is to merge this PR without fixing this? But, it seems like we should bring in a fix to #2930 and #3590 on b4b-dev. What do you think @slevis-lmwg? |
|
Oh, I see, this file path has 258 characters: I recommend running the same test manually (using Regarding your second question, I would start by adding milestones to these two issues. |
|
I had trouble getting the failing test to run by hand. But, got it to work by running a single test from run_sys_tests. The by hand tests at failed at runtime with problems recognizing the ctsm_pylib environment. I think this tells me that the ctsm_pylib isn't inherited into runtime for at least these tests. I'm not sure why. But, something that we may need to look into. |
|
I'm going to bypass the requirement for a review (since this is just an update), to expedite this. It's Thanksgiving eve, and I'm not sure I can get someone to do a quick review. And with a branch update like this there doesn't seem to be enough of a need for it. |
|
Erik, I can review/approve. |
Worth opening an issue. I wonder whether it's an issue specific to this test, because I have not had trouble submitting ./create_test successfully recently. |
slevis-lmwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR merges the latest master to the 5.4 branch.
Description of changes
Updates the ctsm5.4 alpha branch to the latest master tag ctsm5.3.085
Specific notes
Testing performed, if any: Will run standard testing