Skip to content

Conversation

@ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Nov 24, 2025

Description of changes

Updates the ctsm5.4 alpha branch to the latest master tag ctsm5.3.085

Specific notes

Testing performed, if any: Will run standard testing

rgknox and others added 30 commits July 24, 2025 11:06
…tream

docs-build-and-deploy: Only run on upstream
…e for CTSM, this compiles with intel on Derecho
…e method a bit, so that varnames and name aren't sent in, also have to make sdat public, so that the dshr_fldbun_getFldPtr method can use it's internal components
…ilename was incorrect as well as a typo for C13 in the Advance and Interp routines
…n be used easier in the code, this increases memory, but matches the rest of CTSM better and isolates the handling of the grid for the C14 data which makes it easier for the grid to change, this is a prestep to moving to streams as this is how streams works
…mfile

set_paramfile: Allow simply setting all of a parameter to a single value
@ekluzek ekluzek added code health improving internal code structure to make easier to maintain (sustainability) usability Improve or clarify user-facing options labels Nov 24, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Nov 24, 2025
@ekluzek ekluzek changed the title Update ctsm5.4 alpha branch to ctsm5.3.085 alpha-ctsm5.4.CMIP7.20.ctsm5.3.085: Update ctsm5.4 alpha branch to ctsm5.3.085 Nov 24, 2025
@ekluzek ekluzek changed the title alpha-ctsm5.4.CMIP7.20.ctsm5.3.085: Update ctsm5.4 alpha branch to ctsm5.3.085 alpha-ctsm5.4.CMIP7.19.ctsm5.3.085: Update ctsm5.4 alpha branch to ctsm5.3.085 Nov 25, 2025
@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 25, 2025

Derecho testing of aux_clm is as expected other than this test:

RXCROPMATURITYSKIPGEN_Ld1097.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput

which failed at RUN. It passes in the previous alpha 19 tag off of ctsm5.3.082 and it passes in ctsm5.3.085. I'm resubmitting to see if that solves it.

@slevis-lmwg
Copy link
Contributor

Erik, if I'm looking in the correct directory
/glade/derecho/scratch/erik/tests_Actsm54CMIP719ctsm5385acl/RXCROPMATURITYSKIPGEN_Ld1097.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput.GC.Actsm54CMIP719ctsm5385acl_int.gddgen/run
then the cesm.log has this error:
Abort with message Specified netCDF file does not exist

Is it not finding this file surfdata_10x15_hist_1850_78pfts_c251022.all_crops_everywhere.nc?

@slevis-lmwg
Copy link
Contributor

That file exists, so is it failing to find a datm file, such as /glade/campaign/cesm/cesmdata/inputdata/atm/datm7/CO2/fco2_datm_global_simyr_1750-2014_CMIP6_c180929.nc?

@slevis-lmwg
Copy link
Contributor

That one also exists. I think the name of the file that doesn't exist is not appearing in the log files...

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 25, 2025

It looks like the problem is due to #2930 which I just closed and then realized it needed to be reopened. The problem occurs at runtime rather than preview_namelist time right now.

My inclination is to merge this PR without fixing this? But, it seems like we should bring in a fix to #2930 and #3590 on b4b-dev. What do you think @slevis-lmwg?

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Nov 25, 2025

Oh, I see, this file path has 258 characters: /glade/derecho/scratch/erik/tests_Actsm54CMIP719ctsm5385acl/RXCROPMATURITYSKIPGEN_Ld1097.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput.GC.Actsm54CMIP719ctsm5385acl_int.gddgen/surfdata_10x15_hist_1850_78pfts_c251022.all_crops_everywhere.nc
In other words if your /tests directory had a default name (e.g. tests_1121-130823de) then the test would PASS.

I recommend running the same test manually (using ./create_test RX... -c <old_baseline> -g <new_baseline) to confirm that it passes and to end up with the correct TestStatus in the new baseline.

Regarding your second question, I would start by adding milestones to these two issues.

@ekluzek ekluzek moved this from Ready to start (or start again) to In progress - release/externals / MOSART / RTM / mizu etc. tags in CTSM: Upcoming tags Nov 25, 2025
@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 27, 2025

I had trouble getting the failing test to run by hand. But, got it to work by running a single test from run_sys_tests. The by hand tests at failed at runtime with problems recognizing the ctsm_pylib environment. I think this tells me that the ctsm_pylib isn't inherited into runtime for at least these tests. I'm not sure why. But, something that we may need to look into.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 27, 2025

I'm going to bypass the requirement for a review (since this is just an update), to expedite this. It's Thanksgiving eve, and I'm not sure I can get someone to do a quick review. And with a branch update like this there doesn't seem to be enough of a need for it.

@ekluzek ekluzek changed the base branch from master to alpha-ctsm5.4.CMIP7 November 27, 2025 00:21
@slevis-lmwg
Copy link
Contributor

Erik, I can review/approve.

@slevis-lmwg
Copy link
Contributor

I had trouble getting the failing test to run by hand. But, got it to work by running a single test from run_sys_tests. The by hand tests at failed at runtime with problems recognizing the ctsm_pylib environment. I think this tells me that the ctsm_pylib isn't inherited into runtime for at least these tests. I'm not sure why. But, something that we may need to look into.

Worth opening an issue. I wonder whether it's an issue specific to this test, because I have not had trouble submitting ./create_test successfully recently.

Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR merges the latest master to the 5.4 branch.

@github-project-automation github-project-automation bot moved this from In progress - release/externals / MOSART / RTM / mizu etc. tags to In progress - master in CTSM: Upcoming tags Nov 27, 2025
@ekluzek ekluzek merged commit 3cfe210 into ESCOMP:alpha-ctsm5.4.CMIP7 Nov 27, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Nov 27, 2025
@ekluzek ekluzek deleted the update_ctsm54_to_5385 branch November 27, 2025 00:47
@slevis-lmwg slevis-lmwg moved this from Done (non release/external) to release/externals tags done in CTSM: Upcoming tags Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability usability Improve or clarify user-facing options

Projects

Status: release/externals tags done
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants